Skip to content

Commit

Permalink
Remove using namespace from lir/postgen.h
Browse files Browse the repository at this point in the history
Summary: `using namespace` in a header is a bad idea.

Reviewed By: DinoV

Differential Revision: D56280777

fbshipit-source-id: 213ec8edb7b89cd430bea1310418a04bea7eb99a
  • Loading branch information
swtaarrs authored and facebook-github-bot committed Apr 18, 2024
1 parent 5792932 commit cdccde3
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions cinderx/Jit/lir/postgen.h
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,11 @@
#include "cinderx/Jit/codegen/environ.h"
#include "cinderx/Jit/lir/rewrite.h"

using namespace jit::codegen;

namespace jit::lir {
// Rewrites after LIR generation
class PostGenerationRewrite : public Rewrite {
public:
PostGenerationRewrite(lir::Function* func, Environ* env)
PostGenerationRewrite(lir::Function* func, codegen::Environ* env)
: Rewrite(func, env) {
// rewriteInlineHelper should occur before other rewrites.
registerOneRewriteFunction(rewriteInlineHelper, 0);
Expand Down Expand Up @@ -45,7 +43,9 @@ class PostGenerationRewrite : public Rewrite {
instr_iter_t instr_iter);

// Rewrite LoadArg to Bind and allocate a physical register for its input.
static RewriteResult rewriteLoadArg(instr_iter_t instr_iter, Environ* env);
static RewriteResult rewriteLoadArg(
instr_iter_t instr_iter,
codegen::Environ* env);

// rewrite BatchDecref instructions
static RewriteResult rewriteBatchDecrefInstrs(instr_iter_t instr_iter);
Expand Down

0 comments on commit cdccde3

Please sign in to comment.