[ci] Temporary fork runtime_commit_artifacts #30472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
poteto
added a commit
that referenced
this pull request
Jul 25, 2024
Unfortunately creating a workflow that depends on another worfklow run requires it to first be merged into main, so I can't really test porting this without landing it first. To do this safely, I've left the original job intact for DiffTrain and added a forked file. This fork only currently downloads the artifact from the HEAD commit in GH actions; I've removed the steps that push to the protected branches for now while I test to see if this works as expected. This workflow needs to depend on the runtime_build_and_test workflow being complete because otherwise it will fail since the artifacts haven't been built yet. ghstack-source-id: 0f9cebc5251ee8339ca95e2d658d7e75fc2a213e Pull Request resolved: #30472
facebook-github-bot
added
CLA Signed
React Core Team
poteto
commented
Jul 25, 2024
Comment on lines
+55
to
+74
| - uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: 18.20.1 | ||
| cache: yarn | ||
| cache-dependency-path: yarn.lock | ||
| - name: Restore cached node_modules | ||
| uses: actions/cache@v4 | ||
| id: node_modules | ||
| with: | ||
| path: "**/node_modules" | ||
| key: ${{ runner.arch }}-${{ runner.os }}-modules-${{ hashFiles('yarn.lock', 'scripts/release/yarn.lock') }} | ||
| - run: yarn install --frozen-lockfile | ||
| - run: yarn install --frozen-lockfile | ||
| working-directory: scripts/release | ||
| - name: Download artifacts for base revision | ||
| run: | | ||
| git fetch origin main | ||
| GH_TOKEN=${{ github.token }} scripts/release/download-experimental-build-ghaction.js --commit=$(git rev-parse origin/main) | ||
| - name: Display structure of build | ||
| run: ls -R build |
There was a problem hiding this comment.
These are newly added and is the same script we use to download the base build for sizebot and for the devtools regression tests, so it's already been tested.
|
Comparing: 720a982...ef82168 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
poteto
added a commit
that referenced
this pull request
Jul 25, 2024
Unfortunately creating a workflow that depends on another worfklow run requires it to first be merged into main, so I can't really test porting this without landing it first. To do this safely, I've left the original job intact for DiffTrain and added a forked file. This fork only currently downloads the artifact from the HEAD commit in GH actions; I've removed the steps that push to the protected branches for now while I test to see if this works as expected. This workflow needs to depend on the runtime_build_and_test workflow being complete because otherwise it will fail since the artifacts haven't been built yet. ghstack-source-id: 0f9cebc5251ee8339ca95e2d658d7e75fc2a213e Pull Request resolved: #30472
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Unfortunately creating a workflow that depends on another worfklow run
requires it to first be merged into main, so I can't really test porting
this without landing it first.
To do this safely, I've left the original job intact for DiffTrain and
added a forked file. This fork only currently downloads the artifact
from the HEAD commit in GH actions; I've removed the steps that push to
the protected branches for now while I test to see if this works as
expected.
This workflow needs to depend on the runtime_build_and_test workflow
being complete because otherwise it will fail since the artifacts
haven't been built yet.