Fix memory leak bug in RCTModalHost #9295
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solves #9265 Previously _hostViews was allocated if it already exists. Now _hostViews will be allocated if it doesn't exist. ie, only one time.
|
By analyzing the blame information on this pull request, we identified @javache and @jemise111 to be potential reviewers. |
ghost
added
GH Review: review-needed
CLA Signed
|
@facebook-github-bot shipit |
ghost
added
GH Review: accepted
Import Started
|
Thanks for importing.If you are an FB employee go to Phabricator to review internal test results. |
ghost
added
the
CLA Signed
|
@ide: I see that facebook-github-bot-3 closed this PR. I couldn't understand what this meant. Could you please shed some light in to this? |
|
It means your PR was merged, see the commit hash in the message. |
|
Awesome 🎉 . Thank you @ide |
cmcewen
pushed a commit
to cmcewen/react-native
that referenced
this pull request
Aug 15, 2016
Summary: This PR addresses issue facebook#9265. Negated the condition that checks if `_hostViews` exists so that `_hostViews` will be allocated only if it doesn't exist Closes facebook#9295 Differential Revision: D3686214 fbshipit-source-id: ec0caac99d231786eefad023f3f0ed44a79f687e
mpretty-cyro
pushed a commit
to HomePass/react-native
that referenced
this pull request
Aug 25, 2016
Summary: This PR addresses issue facebook#9265. Negated the condition that checks if `_hostViews` exists so that `_hostViews` will be allocated only if it doesn't exist Closes facebook#9295 Differential Revision: D3686214 fbshipit-source-id: ec0caac99d231786eefad023f3f0ed44a79f687e
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #9265.
Negated the condition that checks if
_hostViewsexists so that_hostViewswill be allocated only if it doesn't exist