Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Circle] Update danger token #18111

Closed
wants to merge 2 commits into from
Closed

Conversation

hramos
Copy link
Contributor

@hramos hramos commented Feb 27, 2018

No description provided.

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. cla signed labels Feb 27, 2018
@pull-bot
Copy link

Fails
🚫

Danger failed to run dangerfile.js.

Error TypeError

Cannot read property 'toLowerCase' of null
TypeError: Cannot read property 'toLowerCase' of null
    at Object.<anonymous> (dangerfile.js:47:52)
    at Module._compile (module.js:643:30)
    at requireFromString (/home/circleci/react-native/bots/node_modules/require-from-string/index.js:28:4)
    at Object.<anonymous> (/home/circleci/react-native/bots/node_modules/danger/distribution/runner/runners/inline.js:96:21)
    at step (/home/circleci/react-native/bots/node_modules/danger/distribution/runner/runners/inline.js:32:23)
    at Object.next (/home/circleci/react-native/bots/node_modules/danger/distribution/runner/runners/inline.js:13:53)
    at /home/circleci/react-native/bots/node_modules/danger/distribution/runner/runners/inline.js:7:71
    at new Promise (<anonymous>)
    at __awaiter (/home/circleci/react-native/bots/node_modules/danger/distribution/runner/runners/inline.js:3:12)
    at Object.runDangerfileEnvironment (/home/circleci/react-native/bots/node_modules/danger/distribution/runner/runners/inline.js:67:12)

Dangerfile

42|   const idea = 'This PR appears to be missing a Test Plan.';
43|   warn(`${title} - <i>${idea}</i>`);
44| }
45| 
46| // Regex looks for given categories, types, a file/framework/component, and a message - broken into 4 capture groups
------------------------------------------------------^
47| const releaseNotesRegex = /\[(ANDROID|CLI|DOCS|GENERAL|INTERNAL|IOS|TVOS|WINDOWS)\]\s*?\[(BREAKING|BUGFIX|ENHANCEMENT|FEATURE|MINOR)\]\s*?\[(.*)\]\s*?\-\s*?(.*)/ig;
48| const includesReleaseNotes = danger.github.pr.body.toLowerCase().includes('release notes');
49| const correctlyFormattedReleaseNotes = releaseNotesRegex.test(danger.github.pr.body);
50| const releaseNotesCaptureGroups = releaseNotesRegex.exec(danger.github.pr.body);

Generated by 🚫 dangerJS

@facebook-github-bot facebook-github-bot added the Import Started This pull request has been imported. This does not imply the PR has been approved. label Feb 27, 2018
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Import Started This pull request has been imported. This does not imply the PR has been approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants