-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Babel to 7.0.0 🎉 #233
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Codecov Report
@@ Coverage Diff @@
## master #233 +/- ##
=========================================
Coverage ? 85.56%
=========================================
Files ? 139
Lines ? 4538
Branches ? 700
=========================================
Hits ? 3883
Misses ? 585
Partials ? 70 Continue to review full report at Codecov.
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
"@babel/plugin-transform-flow-strip-types": "7.0.0-beta.56", | ||
"@babel/plugin-transform-modules-commonjs": "7.0.0-beta.56", | ||
"@babel/register": "7.0.0-beta.56", | ||
"@babel/core": "7.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since Babel 7 releases won't contain breaking change, you can/should use ^7.0.0
everywhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yeah, sure, silly me 😣
Yay!! 🎉 I'm also working on an internal commit to upgrade to Since at Facebook we use the master version of |
Good to hear @rafeca ! Keep up the excellent work 😀 |
Hey @rafeca , I saw you merged Babel 7 into master, so I guess we can close this pull request ! Would it be possible to bump metro to a new version so that we can create a new RC for react native 0.57 ? Thanks 🎉 |
Summary
Thanks to babel team incredible work, they released babel 7 🎉 , here's an update to make sure we are not anymore on a beta version. This will enforce compatibily once every other package updates to babel 7
Test plan
yarn test is OK.