docs(deployment): add permissions config to github action file in v2.4.3 #9377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…4.3... this is already documented in the latest version by commit 35183d7 See also facebook#8877 This is also working for v2.4.3 and needed for using GitHub Pages and Actions with the default setting for the action's automatic GITHUB_TOKEN
chillinPanda
requested review from
slorber,
lex111 and
Josh-Cena
as code owners
3 tasks
✅ [V2]Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
|
Thanks ;) |
slorber
added
the
pr: documentation
This was referenced Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-flight checklist
Motivation
this is already documented in the latest version by commit 35183d7
See also #8877
This is also working for v2.4.3 and needed for using GitHub Pages and Actions with the default setting for the action's automatic GITHUB_TOKEN
Since v2.4.3 is the current version, which is shown by default, doc readers should also see the permission config, so they don't run into permission issues.
Test Plan
no code change, only mdx
Test links
Scroll down to
Triggering deployment with GitHub ActionsSame-> ExpanderGitHub action files-> Code box.github/workflows/deploy.ymlRemote-> ExpanderGitHub action files-> Code box.github/workflows/deploy.ymlDeploy preview: https://deploy-preview-9377--docusaurus-2.netlify.app/docs/deployment#triggering-deployment-with-github-actions
Related issues/PRs