-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add DeploymentConfigRollback object to openshift model #5772
Conversation
b06315b
to
7450058
Compare
7450058
to
7758077
Compare
@rohanKanojia unit test has been added. |
DeploymentConfigRollback actual = new DeploymentConfigRollbackBuilder() | ||
.withName("app-to-rollback") | ||
.withSpec( | ||
new DeploymentConfigRollbackSpecBuilder().withFrom( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is .withNewSpec()
available here?
.withNewSpec()
.withFrom( )
.endSpec
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it is. This helps reduce the nesting. Thanks for the idea.
.withName("app-to-rollback") | ||
.withSpec( | ||
new DeploymentConfigRollbackSpecBuilder().withFrom( | ||
new ObjectReference( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not use ObjectReferenceBuilder here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oversight, will update.
7758077
to
a7e2fcc
Compare
a7e2fcc
to
a14c534
Compare
@mluckam : What is the use case for this change? How do you plan to use this object from openshift-model? Do you also plan to make subsequent changes in OpenShiftClient DSL ? |
Quality Gate passedIssues Measures |
The DeploymentConfigRollback is utilized to rollback a DeploymentConfig via the API path "/apis/apps.openshift.io/v1/namespaces/{namespace}/deploymentconfigs/{name}/rollback", see documentation. The model DeploymentConfigRollback was not currently in this project, but available in the dependent model project. Currently I am migrating to utilizing the kubernetes and openshift models from this project. Once the models from this project are utilized, a next step would be to transition from interacting with the API via an HTTP client, to utilizing the OpenShiftClient. This may be several months away though. Until this migration occurs, I do not have plans to update the OpenShiftClient DSL. |
@mluckam : Could you please create an issue for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thx!
Description
added DeploymentConfigRollback object to openshift model
https://docs.openshift.com/container-platform/4.10/rest_api/workloads_apis/deploymentconfigrollback-apps-openshift-io-v1.html
Type of change
test, version modification, documentation, etc.)
Checklist