Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refined leaderelector lifecycle and logging #5747

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

shawkins
Copy link
Contributor

@shawkins shawkins commented Feb 6, 2024

Description

closes: #5635

This should clear up a couple of points of confusion brought up on that issue. We can treat a request to have the LeaderElector be reusable as a separate enhancement.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

Copy link

sonarqubecloud bot commented Feb 6, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

60.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@manusa manusa added this to the 6.11.0 milestone Feb 7, 2024
@manusa manusa merged commit ba94776 into fabric8io:main Feb 7, 2024
16 of 19 checks passed
@rohanKanojia rohanKanojia changed the title fix: refined leaderelector lifecylce and logging fix: refined leaderelector lifecycle and logging Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to update lease lock in fabric client with kubernetes version : v1.25.11-eks-a5565ad
3 participants