Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updating to latest sundrio #5308

Merged
merged 1 commit into from
Jul 5, 2023
Merged

updating to latest sundrio #5308

merged 1 commit into from
Jul 5, 2023

Conversation

shawkins
Copy link
Contributor

@shawkins shawkins commented Jul 5, 2023

Description

Updating to the latest sundrio to pick up serveral enhancements / fixes. This removes the fluent impls, deprecated methods, as well as typed methods that have a general method referencing a parent type.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@shawkins shawkins marked this pull request as ready for review July 5, 2023 10:59
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

50.0% 50.0% Coverage
25.0% 25.0% Duplication

@shawkins shawkins mentioned this pull request Jul 5, 2023
Closed
@manusa manusa mentioned this pull request Jul 5, 2023
Closed
@manusa manusa added this to the 6.8.0 milestone Jul 5, 2023
@manusa manusa merged commit db8778f into fabric8io:master Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oscerd oscerd oscerd approved these changes

@sunix sunix sunix approved these changes

@manusa manusa manusa approved these changes

@rohanKanojia rohanKanojia Awaiting requested review from rohanKanojia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.8.0
Development

Successfully merging this pull request may close these issues.
4 participants
@shawkins @manusa @sunix @oscerd