Various proxy changes #5178
Merged
Various proxy changes #5178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawkins
requested review from
manusa,
oscerd,
rohanKanojia and
sunix
as code owners
shawkins
force-pushed
the
iss1335
branch
2 times, most recently
from
46ce011 to
cfb20eb
Compare
|
SonarCloud Quality Gate failed. |
manusa
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #5086
Fix #1335
Addresses Add support for socks proxies #5086 by allowing socks proxy urls to be used. A new config HttpClient.Builder property called proxyType was added for this. Based upon the implementations I used an enum, but you could also consider using a just a string to capture support for things like socks5h.
There was also a bug with the vertx client and proxy support - the auth header was not being applied for websocket requests. The common interceptor was refactored and applied to vertx as well
Addresses NO_PROXY settings #1335 / Add support for socks proxies #5086 by ensuring that additionalConfig can be used consistently across the client types - and applied just before the final client is built so that its changes are not overriden. The changes also try to infer when it's okay to default the proxy configuration to whatever is supported to the client - we'll only force "no proxy" on the client when HttpConfigUtils determines our no.proxy / NO_PROXY setting is applicable. If that seems too broad, then we'll need to introduce yet another config property.
Type of change
test, version modification, documentation, etc.)
Checklist