Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #5095: moving the enforcement to requestTimeout #5099

Merged
merged 1 commit into from
May 9, 2023
Merged

fix #5095: moving the enforcement to requestTimeout #5099

merged 1 commit into from
May 9, 2023

Conversation

shawkins
Copy link
Contributor

@shawkins shawkins commented May 4, 2023 •
edited by manusa
Loading

Description

Fix #5095

After moving the retry logic, having the fail-safe enforcement of the requestTimeout above that does not make sense. This moves the handling to the standard layer instead.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@manusa manusa added this to the 6.6.1 milestone May 4, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@manusa manusa merged commit f1185a0 into fabric8io:master May 9, 2023
@manusa manusa mentioned this pull request May 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manusa manusa manusa approved these changes

@oscerd oscerd Awaiting requested review from oscerd

@rohanKanojia rohanKanojia Awaiting requested review from rohanKanojia

@sunix sunix Awaiting requested review from sunix

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.6.1
Development

Successfully merging this pull request may close these issues.

StandardHttpClient.retryWithExponentialBackoff leads to TimeoutException hiding underlying issues
2 participants
@shawkins @manusa