-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This change seems to be breaking my application when upgrading from 6.5.0 to 6.5.1? #5298
Comments
Moved to a separate issue. Is this effectively a bug with openshift that fabric8 was compenstating for but other clients such as kubectl or oc are not? My understanding with 403 is that re-authentication won't make any difference. Or is there something else going on here? |
Looks like the 403 handling has been there from the start: a926786 I am authenticating with username and password. From what I see in the exception stacktrace |
Yes and we could not figure out why that handling was there.
Ah that is the issue, the auth interceptor is allowing the initial request to go through - even if the token does not yet exist. If the token isn't set, it should authenticate first - that will require a code change. Right now it will trigger a refresh and requests will fail until that completes - do you see that later reqeusts are successful? |
### What changes were proposed in this pull request? The pr aims to upgrade kubernetes-client from 6.7.2 to 6.8.0. ### Why are the changes needed? - The newest version brings some bug fixed & improvment, eg: Fix fabric8io/kubernetes-client#5221: Empty kube config file causes NPE Fix fabric8io/kubernetes-client#5281: Ensure the KubernetesCrudDispatcher's backing map is accessed w/lock Fix fabric8io/kubernetes-client#5298: Prevent requests needing authentication from causing a 403 response Fix fabric8io/kubernetes-client#5233: Generalized SchemaSwap to allow for cycle expansion Fix fabric8io/kubernetes-client#5262: all built-in collections will omit empty in their serialized form. - The full release notes: https://github.com/fabric8io/kubernetes-client/releases/ ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass GA. Closes #42142 from panbingkun/SPARK-44537. Authored-by: panbingkun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
### What changes were proposed in this pull request? The pr aims to upgrade kubernetes-client from 6.7.2 to 6.8.0. ### Why are the changes needed? - The newest version brings some bug fixed & improvment, eg: Fix fabric8io/kubernetes-client#5221: Empty kube config file causes NPE Fix fabric8io/kubernetes-client#5281: Ensure the KubernetesCrudDispatcher's backing map is accessed w/lock Fix fabric8io/kubernetes-client#5298: Prevent requests needing authentication from causing a 403 response Fix fabric8io/kubernetes-client#5233: Generalized SchemaSwap to allow for cycle expansion Fix fabric8io/kubernetes-client#5262: all built-in collections will omit empty in their serialized form. - The full release notes: https://github.com/fabric8io/kubernetes-client/releases/ ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass GA. Closes apache#42142 from panbingkun/SPARK-44537. Authored-by: panbingkun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Originally posted by @jpraet in #4970 (comment)
The text was updated successfully, but these errors were encountered: