triangle : add test template #2016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmccandless
suggested changes
Oct 3, 2019
exercises/triangle/.meta/template.j2
Outdated
| def test_{{ case["description"] | to_snake }}(self): | ||
| input = {{ case["input"]["sides"] }} | ||
| expected = {{ case["expected"] }} | ||
| self.assertEqual({{ case["property"] }}(input), expected) |
There was a problem hiding this comment.
I'd recommend putting everything inside the assertEqual call instead of using the input and expected variables here. You can spread things out like so for template readability, and the generator will put everything on a single line in generation:
self.assertEqual(
{{ case["property"] }}({{ case["input"]["sides"] }}),
{{ case["expected"] }}
)
|
Made changes as requested. Thanks ! |
cmccandless
suggested changes
Oct 3, 2019
exercises/triangle/.meta/template.j2
Outdated
| class {{ case["description"] | camel_case }}Test(unittest.TestCase): | ||
| {% for case in case["cases"] %} | ||
| def test_{{ case["description"] | to_snake }}(self): | ||
| self.assertEqual({{ case["property"] }}({{ case["input"]["sides"] }}), {{ case["expected"] }}) |
There was a problem hiding this comment.
OK, smaller diff let me see this one. From our conventions:
We use assertIs(actual, True) and assertIs(actual, False) rather than assertTrue(actual) or assertFalse(actual) (#419).
Suggested change
| self.assertEqual({{ case["property"] }}({{ case["input"]["sides"] }}), {{ case["expected"] }}) | |
| self.assertIs({{ case["property"] }}({{ case["input"]["sides"] }}), {{ case["expected"] }}) |
There was a problem hiding this comment.
changed to assertIs as per conventions. Thanks.
cmccandless
approved these changes
Oct 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.