Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add skipping pulls by default if present, add --force flag and return on pull error #45

Merged
merged 1 commit into from
Aug 19, 2022

Conversation

tylerslaton
Copy link
Collaborator

@tylerslaton tylerslaton commented Aug 19, 2022

Doing three things:

  1. Returning errors from the pull so the program closes out when reaching an error there
  2. Adding logic to skip pulling if the image is already present locally
  3. Adding a new --force flag that forces a pull to occur even if the image is present locally

Note: I started to implement a test for this but was hitting some unexpected complexity when attempting to pull an image within a test. I'll have a follow-up that introduces some refactors to make that form of testing easier.

Closes #43

src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Show resolved Hide resolved
@exdx
Copy link
Owner

exdx commented Aug 19, 2022

Closes #43

@tylerslaton tylerslaton force-pushed the add-use-local branch 2 times, most recently from 9d106de to 576c8c9 Compare August 19, 2022 19:07
Copy link
Owner

@exdx exdx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good, a lot closer to what I had in mind originally. A few nits but I think this is largely good to go.

src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
@tylerslaton tylerslaton changed the title feat: add --use-local flag and return errors from pulling feat: add skipping pulls by default if present, add --force flag and return on pull error Aug 19, 2022
@exdx exdx merged commit a8c6920 into exdx:main Aug 19, 2022
@tylerslaton tylerslaton deleted the add-use-local branch August 19, 2022 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when copying content from local image
3 participants