-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: update testing suite to write to a more visible path #21
Conversation
9d29330
to
49fc858
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Can we go ahead and add cleanup for the directory while we're making this change?
8a17940
to
731ce96
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any idea on what happens if the test case assertion fails? Does it drop down to the remove_dir_all function, or does the function flow immediately stop there?
731ce96
to
3bdddbf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Yes, that's a good call-out. We need the equivalent of a |
I would think that it would fail to clean-up the directory so thats a good callout. Let me try and find some sort of defer in rust. |
There's some workaround using the |
3bdddbf
to
69dcb36
Compare
Summary
With this fix the testing suite now writes to
./test_runs
which is a local directory that git ignores. This should make these runs more visible to easily delete.