Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug with failing double conversion #34

Closed
samansmink opened this issue Oct 30, 2024 · 2 comments · Fixed by #36
Closed

Bug with failing double conversion #34

samansmink opened this issue Oct 30, 2024 · 2 comments · Fixed by #36

Comments

@samansmink
Copy link

First of all, amazing work here @archiewood! Being able to just SELECT * FROM '<gsheets urls>' is really amazing! Also the OAuth works super smoothly.

Minor snag I hit:

Invalid Error: stod: no conversion

for a sheet containing:

col a col b col c
1 value1 blabla1
2 value2 blabla2
3 value3 blabla3
  value4 blabla4

Perhaps it makes sense to look into DuckDB's casting functionality instead of using stod? DuckDB has Value::TryCastAs which should allow you to do this a bit more safely.

@archiewood
Copy link
Member

Thanks for reporting.
Types and type conversion are very rudimentary at this stage. Will investigate Value::TryCastAs

@archiewood
Copy link
Member

Reproduced

@archiewood archiewood linked a pull request Nov 1, 2024 that will close this issue
archiewood added a commit that referenced this issue Nov 1, 2024
fix Bug with failing double conversion #34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants