Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eof: Fix EOF builtin names unintentionally reserved outside of EOF #15700

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

eof: Fix EOF builtin names unintentionally reserved outside of EOF #15700

wants to merge 1 commit into from
+37 −1

Conversation

rodiazet
Copy link
Contributor

@rodiazet rodiazet commented Jan 9, 2025 •
edited
Loading

Resolves: #15672

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2025

Thank you for your contribution to the Solidity compiler! A team member will follow up shortly.

If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother.

If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix.

@rodiazet rodiazet force-pushed the eof-reserved-names-fix branch from 7c98754 to 4e697bf Compare January 9, 2025 11:29
nikola-matic
nikola-matic reviewed Jan 9, 2025
View reviewed changes
test/libyul/yulSyntaxTests/eof/eof_builtins_names_reserved.yul
Comment on lines +3 to +8
function dataloadn() {}
function rjump() {}
function rjumpi() {}
function callf() {}
function jumpf() {}
function retf() {}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are any of these implemented in EOF, i.e. callable, like ext* calls?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikola-matic nikola-matic nikola-matic left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
external contribution ⭐
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some EOF-specific Yul builtin names are reserved even outside of EOF
2 participants
@rodiazet @nikola-matic