fix: EoA pattern recognition #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized that the "EoA pattern recognition" had been re-enabled, and that the test fix I pushed in
masterwas actually the wrong fix.The reason for the tests failing, is that the leaf pattern hasn't been changed to "Nyota" in that test, while the encoding code did. So I updated the test to make sure that it was testing the right pattern.
There is another issue: no check was made to ensure that the version were 0. Which means that any
LeafNodethat had only slot 0 and 1 set, with slot 1 being theEmptyHash, would be considered an EoA and encoded as such... but ifversion,code sizeand the reserved space was non-zero, it would not be saved while being serialized! This is a very rare occurrence, but definitely a bug.