Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify: only check post root if provided #462

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

gballet
Copy link
Member

@gballet gballet commented Jan 6, 2025

Don't try to verify the validity of the provided post-state root if it isn't provided.

This is necessary for gballet/go-ethereum#527 to work.

@gballet gballet added the bug Something isn't working label Jan 6, 2025
Copy link
Collaborator

@jsign jsign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I see that the tests fail, is this related to this bug still or another?

@gballet
Copy link
Member Author

gballet commented Jan 6, 2025

It's related to a bug we introduced when disabling the eoa optimization. I am about to push a fix.

@gballet gballet force-pushed the optional-post-root-check-in-verify branch from 7674ab5 to 23faab4 Compare January 6, 2025 11:45
@gballet gballet merged commit 3425fbd into master Jan 6, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants