proof: absent key proof doesn't verify #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ignacio Hagopian <[email protected]>
jsign
changed the title
jsign
changed the title
gballet
reviewed
Oct 16, 2023
Signed-off-by: Ignacio Hagopian <[email protected]>
* fix absent keys in proofs Signed-off-by: Ignacio Hagopian <[email protected]> * add POA stub marker Signed-off-by: Ignacio Hagopian <[email protected]> * defensive case Signed-off-by: Ignacio Hagopian <[email protected]> * fixes Signed-off-by: Ignacio Hagopian <[email protected]> * improving comment Signed-off-by: Ignacio Hagopian <[email protected]> --------- Signed-off-by: Ignacio Hagopian <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates a specially crafted unit test that generates proofs that don't verify (i.e: the library isn't self-consistent).
A fix proposal is done in #401 (targeting this branch).I'm separating the unit test from the (proposed, TBD) fix so we can have this branch keep exploring the problem if needed.Note: CI not passing in this branch (as is) is expected since that's the point of the added test.Fix merged.