Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ipa: add new api for creating Fr from big-endian bytes #300

Merged
merged 1 commit into from
Nov 22, 2022
Merged

ipa: add new api for creating Fr from big-endian bytes #300

merged 1 commit into from
Nov 22, 2022

Conversation

jsign
Copy link
Collaborator

@jsign jsign commented Nov 21, 2022 •
edited
Loading

This PR adds a new API in the ipa package to build a Fr from a big-endian byte slice.

This is used in this other go-ethereum PR.

@jsign jsign self-assigned this Nov 21, 2022
@jsign jsign mentioned this pull request Nov 21, 2022
Merged
@jsign jsign marked this pull request as ready for review November 21, 2022 22:32
@jsign jsign requested a review from gballet November 21, 2022 22:33
gballet
gballet approved these changes Nov 22, 2022
View reviewed changes
Copy link
Member

@gballet gballet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Also, "this is sparta!" (sorry for the terrible pun)

@gballet gballet merged commit 75ceda2 into master Nov 22, 2022
@jsign jsign deleted the jsign/ipabe branch November 23, 2022 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gballet gballet gballet approved these changes

Assignees

@jsign jsign

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsign @gballet