Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new check_mods function for generators #3970

Merged
merged 5 commits into from
Oct 14, 2024
Merged

Conversation

jtraglia
Copy link
Member

@jtraglia jtraglia commented Oct 8, 2024

This function is meant to prevent untested modules in generators. Sometimes we forget to update the all_mods dictionary in a generator and it's difficult to tell; typically a client team will reach out to us.

Given all_mods and the package name (eg epoch_processing), check_mods will point out when there's a missing or unexpected module in all_mods. It does this by comparing all_mods to the modules list for that package.

@jtraglia jtraglia requested a review from hwwhww October 14, 2024 14:07
Copy link
Contributor

@hwwhww hwwhww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see it will save my day. Thank you @jtraglia !

@hwwhww hwwhww merged commit 179cde6 into ethereum:dev Oct 14, 2024
26 checks passed
@jtraglia jtraglia deleted the check-mods branch October 14, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants