MetaData and Ping #1684
Merged
MetaData and Ping #1684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
protolambda
reviewed
Mar 25, 2020
|
|
||
| **Protocol ID:** `/eth2/beacon_chain/req/metadata/1/` | ||
|
|
||
| No Request Content. |
There was a problem hiding this comment.
Interesting, the first RPC call without a request content. Does that mean an empty payload, but still a request header with a 0-length in it? Or no bytes at all?
There was a problem hiding this comment.
This came from @AgeManning in his previous PR.
I interpreted it as no bytes at all
There was a problem hiding this comment.
Think we can spec it both ways, let's ask on the call
There was a problem hiding this comment.
Talked to age, was the intention and works on libp2p...
Will change it later if Raul chimes in otherwise
9 tasks
5 tasks
This was referenced Apr 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on @AgeManning's #1673 and the discussion on the recent networking call.
attnetsPingthat sends back and forthmeta_data.seq_numberGetMetaDataRPC method to request a nodes most recentMetaDataattnetsfield is optional