Remove custody_bits and AttestationDataAndCustodyBit #1462
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This was
Merged
. There is some sort of github bug that is showing this asClosed
, but disregard that.These two constructions weren't originally removed from
v0.9.0
to attempt to not disrupt the status quo where unnecessary. As we dig deeper into the Phase 1 spec, the custody bit construction is altered from this original construction to be on a per block basis and the placeholder in phase 0 would eventually have to be removed come phase 1 anyway.I suggest we remove this and release as a
v0.9.1
along with some other minor changes in the queuechangelog:
custody_bits
fromAttestation
bit_0_indices
andbit_1_indices
inIndexedAttestation
with a singularattesting_indices
AttestationDataAndCustodyBit
and replace the attestation signing as just overattestation.data
bls_verify
instead of abls_verify_multiple
inprocess_attestation