Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simple aggregation strategy #1440

Merged
merged 19 commits into from
Oct 28, 2019
Merged

Simple aggregation strategy #1440

merged 19 commits into from
Oct 28, 2019

Conversation

djrtwo
Copy link
Contributor

@djrtwo djrtwo commented Oct 23, 2019 •
edited
Loading

Add the "naive" attestation aggregation strategy to phase 0.

  • add mechanism for selecting which proposers are supposed to aggregate and broadcast
  • add wrapper object AggregateAndProof for broadcasting aggregates that includes a "proof" that the aggregator was selected to aggregate
  • add notes and validation conditions about aggregate and attestation subnet gossip channels
  • rename some topics and vars to reflect new functionality
  • add to and modify some FAQ

@djrtwo djrtwo force-pushed the naive-aggregation branch from 0e27491 to 6445bf7 Compare October 23, 2019 08:39
@djrtwo djrtwo force-pushed the naive-aggregation branch from 6445bf7 to cf1d855 Compare October 23, 2019 08:43
@djrtwo djrtwo force-pushed the naive-aggregation branch from 27b7a3e to 1cda8c8 Compare October 24, 2019 01:10
@djrtwo djrtwo changed the title [WIP] Naive aggregation strategy Naive aggregation strategy Oct 24, 2019
@djrtwo djrtwo requested a review from protolambda October 24, 2019 01:25
protolambda
protolambda reviewed Oct 24, 2019
View reviewed changes
specs/networking/p2p-interface.md Outdated Show resolved Hide resolved
specs/networking/p2p-interface.md Outdated Show resolved Hide resolved
arnetheduck
arnetheduck reviewed Oct 24, 2019
View reviewed changes
specs/networking/p2p-interface.md Outdated Show resolved Hide resolved
specs/networking/p2p-interface.md Outdated Show resolved Hide resolved
specs/validator/0_beacon-chain-validator.md Show resolved Hide resolved
@djrtwo djrtwo force-pushed the naive-aggregation branch from 0fbf0d0 to 6a62cfd Compare October 27, 2019 03:42
@djrtwo djrtwo force-pushed the naive-aggregation branch from 0c6caa5 to d6563bc Compare October 27, 2019 03:51
@djrtwo djrtwo changed the base branch from phase0-simplify to dev October 28, 2019 06:07
hwwhww
hwwhww reviewed Oct 28, 2019
View reviewed changes
specs/networking/p2p-interface.md Outdated Show resolved Hide resolved
specs/networking/p2p-interface.md Outdated Show resolved Hide resolved
specs/networking/p2p-interface.md Outdated Show resolved Hide resolved
@djrtwo djrtwo mentioned this pull request Oct 28, 2019
Merged
hwwhww
hwwhww approved these changes Oct 28, 2019
View reviewed changes
Copy link
Contributor

@hwwhww hwwhww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some presentation suggestions.

specs/networking/p2p-interface.md Outdated Show resolved Hide resolved
specs/networking/p2p-interface.md Outdated Show resolved Hide resolved
specs/networking/p2p-interface.md Outdated Show resolved Hide resolved
specs/networking/p2p-interface.md Outdated Show resolved Hide resolved
specs/networking/p2p-interface.md Outdated Show resolved Hide resolved
@djrtwo djrtwo force-pushed the naive-aggregation branch from afe9433 to 04c20ae Compare October 28, 2019 09:19
@djrtwo
Copy link
Contributor Author

djrtwo commented Oct 28, 2019

addressed your comments @hwwhww !

@djrtwo djrtwo merged commit 60a469b into dev Oct 28, 2019
@djrtwo djrtwo deleted the naive-aggregation branch October 28, 2019 09:42
@hwwhww hwwhww mentioned this pull request Oct 28, 2019
Closed
3 tasks
This was referenced Oct 28, 2019
Closed
Closed
@terencechain terencechain mentioned this pull request Oct 28, 2019
Closed
21 tasks
@hwwhww hwwhww mentioned this pull request Oct 29, 2019
Closed
@djrtwo djrtwo changed the title Naive aggregation strategy Simple aggregation strategy Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@protolambda protolambda protolambda left review comments

@hwwhww hwwhww hwwhww approved these changes

@arnetheduck arnetheduck arnetheduck left review comments

Assignees
No one assigned
Labels
scope:attestation-management scope:networking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@djrtwo @arnetheduck @hwwhww @protolambda