Skip to content

Commit

Permalink
Merge pull request #1658 from ethereum/fc-header-comment
Browse files Browse the repository at this point in the history
fork choice error note
  • Loading branch information
protolambda authored Mar 11, 2020
2 parents 42499a0 + c894f5e commit d4ce5f2
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions specs/phase0/fork-choice.md
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,10 @@ class Store(object):
The provided anchor-state will be regarded as a trusted state, to not roll back beyond.
This should be the genesis state for a full client.

*Note* With regards to fork choice, block headers are interchangeable with blocks. The spec is likely to move to headers for reduced overhead in test vectors and better encapsulation. Full implementations store blocks as part of their database and will often use full blocks when dealing with production fork choice.

_The block for `anchor_root` is incorrectly initialized to the block header, rather than the full block. This does not affect functionality but will be cleaned up in subsequent releases._

```python
def get_forkchoice_store(anchor_state: BeaconState) -> Store:
anchor_block_header = anchor_state.latest_block_header.copy()
Expand Down

0 comments on commit d4ce5f2

Please sign in to comment.