prepare to async: stricter checks

This change is in preparation of the future async refactoring by Ray. It tries
to extract as many changes in boolean conditions as possible, in order to make
more evident identifying eventual logic bugs in the future work.
This proved already useful in at least one case.

src/node/db/AuthorManager.js

@@ -45,7 +45,7 @@ exports.doesAuthorExists = function(authorID, callback)
   db.get("globalAuthor:" + authorID, function(err, author) {
     if (ERR(err, callback)) return;
 
-    callback(null, author != null);
+    callback(null, author !== null);
   });
 }
 
@@ -212,7 +212,7 @@ exports.listPadsOfAuthor = function(authorID, callback)
   db.get("globalAuthor:" + authorID, function(err, author) {
     if (ERR(err, callback)) return;
 
-    if (author == null) {
+    if (author === null) {
       // author does not exist
       callback(new customError("authorID does not exist", "apierror"));
 
@@ -242,7 +242,7 @@ exports.addPad = function(authorID, padID)
   // get the entry
   db.get("globalAuthor:" + authorID, function(err, author) {
     if (ERR(err)) return;
-    if (author == null) return;
+    if (author === null) return;
 
     if (author.padIDs == null) {
       // the entry doesn't exist so far, let's create it
@@ -266,9 +266,9 @@ exports.removePad = function(authorID, padID)
 {
   db.get("globalAuthor:" + authorID, function(err, author) {
     if (ERR(err)) return;
-    if (author == null) return;
+    if (author === null) return;
 
-    if (author.padIDs != null) {
+    if (author.padIDs !== null) {
       // remove pad from author
       delete author.padIDs[padID];
       db.set("globalAuthor:" + authorID, author);

src/node/db/GroupManager.js

@@ -122,7 +122,7 @@ exports.deleteGroup = function(groupID, callback)
         if (ERR(err, callback)) return;
         groups = groups? groups.groupIDs : [];
 
-        if (groups.indexOf(groupID) == -1) {
+        if (groups.indexOf(groupID) === -1) {
           // it's not listed
           callback();
 
@@ -198,7 +198,7 @@ exports.createGroup = function(callback)
 exports.createGroupIfNotExistsFor = function(groupMapper, callback)
 {
   // ensure mapper is optional
-  if (typeof groupMapper != "string") {
+  if (typeof groupMapper !== "string") {
     callback(new customError("groupMapper is not a string", "apierror"));
     return;
   }
@@ -248,7 +248,7 @@ exports.createGroupPad = function(groupID, padName, text, callback)
       exports.doesGroupExist(groupID, function(err, exists) {
         if (ERR(err, callback)) return;
 
-        if (exists == false) {
+        if (!exists) {
           // group does not exist
           callback(new customError("groupID does not exist", "apierror"));
           return;
@@ -303,7 +303,7 @@ exports.listPads = function(groupID, callback)
     if (ERR(err, callback)) return;
 
     // ensure the group exists
-    if (exists == false) {
+    if (!exists) {
       callback(new customError("groupID does not exist", "apierror"));
       return;
     }

src/node/db/SecurityManager.js

@@ -62,7 +62,7 @@ exports.checkAccess = function(padID, sessionCookie, token, password, callback)
     }
   } else {
     // a session is not required, so we'll check if it's a public pad
-    if (padID.indexOf("$") == -1) {
+    if (padID.indexOf("$") === -1) {
       // it's not a group pad, means we can grant access
 
       // get author for this token
@@ -230,7 +230,7 @@ exports.checkAccess = function(padID, sessionCookie, token, password, callback)
 
           // --> grant access
           statusObject = { accessStatus: "grant", authorID: sessionAuthor };
-        } else if (isPasswordProtected && passwordStatus == "wrong") {
+        } else if (isPasswordProtected && passwordStatus === "wrong") {
           // - the pad is password protected but wrong password given
 
           // --> deny access, ask for new password and tell them that the password is wrong
@@ -261,12 +261,12 @@ exports.checkAccess = function(padID, sessionCookie, token, password, callback)
         if (isPublic && !isPasswordProtected) {
           // --> grant access, with author of token
           statusObject = {accessStatus: "grant", authorID: tokenAuthor};
-        } else if (isPublic && isPasswordProtected && passwordStatus == "correct") {
+        } else if (isPublic && isPasswordProtected && passwordStatus === "correct") {
           // - it's public and password protected and password is correct
 
           // --> grant access, with author of token
           statusObject = {accessStatus: "grant", authorID: tokenAuthor};
-        } else if (isPublic && isPasswordProtected && passwordStatus == "wrong") {
+        } else if (isPublic && isPasswordProtected && passwordStatus === "wrong") {
           // - it's public and the pad is password protected but wrong password given
 
           // --> deny access, ask for new password and tell them that the password is wrong

src/node/handler/APIHandler.js

@@ -188,7 +188,7 @@ exports.handle = function(apiVersion, functionName, fields, req, res)
   // check the api key!
   fields["apikey"] = fields["apikey"] || fields["api_key"];
 
-  if (fields["apikey"] != apikey.trim()) {
+  if (fields["apikey"] !== apikey.trim()) {
     res.statusCode = 401;
     res.send({code: 4, message: "no or wrong API Key", data: null});
     return;

src/node/handler/SocketIORouter.js

@@ -95,7 +95,7 @@ exports.setSocketIO = function(_socket) {
           var checkAccessCallback = function(err, statusObject) {
             ERR(err);
 
-            if (statusObject.accessStatus == "grant") {
+            if (statusObject.accessStatus === "grant") {
               // access was granted, mark the client as authorized and handle the message
               clientAuthorized = true;
               handleMessage(client, message);

src/node/padaccess.js

@@ -6,7 +6,7 @@ module.exports = function (req, res, callback) {
   securityManager.checkAccess(req.params.pad, req.cookies.sessionID, req.cookies.token, req.cookies.password, function(err, accessObj) {
     if (ERR(err, callback)) return;
 
-    if (accessObj.accessStatus == "grant") {
+    if (accessObj.accessStatus === "grant") {
       // there is access, continue
       callback();
     } else {