Only optionally grab repotags in raw inspect out #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm still testing this PR, but I wanted to ensure the approach looked good. For my repo it went from 25 seconds for |
|
I really don't know how to test v1. I could just not update the v1 implementation and leave it as is. |
|
Looks right to me. I'm doing a major rewrite and will be dropping v1; I think it's fine to leave as is |
|
Okay, cool. I tested v2 and it's working for me. |
|
Oh wait, so I should revert the v1 change then? |
|
Okay, I reverted the v1 changes. |
For images with a lot of tags it can take a significant amount of time to list tags. This can often cause timeouts causing the operation to fail or if ignore-missing is set wrongly skip an image. This change will only grab tags during "inspect --raw" and not during non-raw inspect or push. Since some repos are so large they always timeout a new parameter --tags has been added to inspect do disable including tags on raw inspect. Signed-off-by: Darren Shepherd <[email protected]>
|
After merging this I can directly update the drone plugin :) |
galexrt
added a commit
to cloudical-io/rook
that referenced
this pull request
Apr 7, 2020
This updates the manifest-tools from v1.0.0 to v1.0.2 to pickup the following fix estesp/manifest-tool#90. Resolves rook#5194 Signed-off-by: Alexander Trost <[email protected]>
galexrt
added a commit
to cloudical-io/rook
that referenced
this pull request
Apr 7, 2020
This updates the manifest-tools from v1.0.0 to v1.0.2 to pickup the following fix estesp/manifest-tool#90. This currently prevents the build to push images to Docker hub. Resolves rook#5194 Signed-off-by: Alexander Trost <[email protected]>
9 tasks
galexrt
added a commit
to cloudical-io/rook
that referenced
this pull request
Apr 7, 2020
This updates the manifest-tools from v1.0.0 to v1.0.2 to pickup the following fix estesp/manifest-tool#90. This currently prevents the build to push images to Docker hub. Resolves rook#5194 Signed-off-by: Alexander Trost <[email protected]>
mergify bot
pushed a commit
to rook/rook
that referenced
this pull request
Apr 7, 2020
This updates the manifest-tools from v1.0.0 to v1.0.2 to pickup the following fix estesp/manifest-tool#90. This currently prevents the build to push images to Docker hub. Resolves #5194 Signed-off-by: Alexander Trost <[email protected]> (cherry picked from commit e5ba1fa)
binoue
pushed a commit
to binoue/rook
that referenced
this pull request
Apr 10, 2020
This updates the manifest-tools from v1.0.0 to v1.0.2 to pickup the following fix estesp/manifest-tool#90. This currently prevents the build to push images to Docker hub. Resolves rook#5194 Signed-off-by: Alexander Trost <[email protected]>
vizv
pushed a commit
to vizv/rook
that referenced
this pull request
Apr 15, 2020
This updates the manifest-tools from v1.0.0 to v1.0.2 to pickup the following fix estesp/manifest-tool#90. This currently prevents the build to push images to Docker hub. Resolves rook#5194 Signed-off-by: Alexander Trost <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For images with a lot of tags it can take a significant amount of time to
list tags. This can often cause timeouts causing the operation to fail
or if ignore-missing is set wrongly skip an image. This change will only
grab tags during "inspect --raw" and not during non-raw inspect or push.
Since some repos are so large they always timeout a new parameter --tags
has been added to inspect do disable including tags on raw inspect.