Prepare v1.0.1 release #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estesp
force-pushed
the
v101-golang-update
branch
from
fc891f4 to
ab9d7c2
Compare
tianon
reviewed
Mar 6, 2020
hack/Dockerfile.windows
Outdated
| @@ -1,3 +1,3 @@ | |||
| FROM microsoft/nanoserver | |||
| FROM mcr.microsoft.com/windows/nanoserver:1909 | |||
There was a problem hiding this comment.
AppVeyor can't 1909 -- if you add APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2019 to your .appveyor.yml, you can get 1809: https://www.appveyor.com/docs/windows-images-software/
There was a problem hiding this comment.
you are better than Google. I won't report how many tabs I currently have open looking for guidance on this :)
There was a problem hiding this comment.
I can't take full credit; see docker-library/python#446. 😄
There was a problem hiding this comment.
In other words, you actually want image: Visual Studio 2019 (no need for APPVEYOR_BUILD_WORKER_IMAGE since you're not a matrix).
estesp
force-pushed
the
v101-golang-update
branch
3 times, most recently
from
042152a to
14e91e9
Compare
Update version; specific focus is on re-building with latest Go 1.13 release to fix s390x bug and apply all Golang fixes in the Go 1.13 release history from 1.13.0 -> 1.13.8 Update MS nanoserver image reference to the Microsoft registry; Appveyor settings to Visual Studio 2019 Signed-off-by: Phil Estes <[email protected]>
estesp
force-pushed
the
v101-golang-update
branch
from
14e91e9 to
ed49e82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update version; specific focus is on re-building with latest Go 1.13
release to fix a potential s390x bug ( #86 ) and apply all Golang fixes in the Go 1.13
release history from 1.13.0 -> 1.13.8
Signed-off-by: Phil Estes [email protected]