Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(matter): serial print instead of log_i #10842

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

SuGlider
Copy link
Collaborator

Description of Change

The Matter Minimum Example has a Serial.print() when decommissioning but not Serial.begin().
The PR fixes this issue and also changes log_i() by Serial.print() in order to make it clearer for the users.

Tests scenarios

Minimum Matter Example here provided + ESP32-S3 and Alexa APP

Related links

None

@SuGlider SuGlider added Type: Bug 🐛 All bugs Type: Example Issue is related to specific example. Area: Matter Issues and Feature Request about Matter Protocol labels Jan 11, 2025
@SuGlider SuGlider added this to the 3.1.1 milestone Jan 11, 2025
@SuGlider SuGlider self-assigned this Jan 11, 2025
Copy link
Contributor

github-actions bot commented Jan 11, 2025

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello SuGlider, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 6b5dd3b

Copy link
Contributor

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32S30‼️ +12K0.00⚠️ +0.80000.000.00
ESP32S20‼️ +13K0.00⚠️ +0.830⚠️ +160.00⚠️ +0.02
ESP32C30‼️ +14K0.00⚠️ +0.89000.000.00
ESP32C60‼️ +14K0.00⚠️ +0.93000.000.00
ESP320‼️ +13K0.00⚠️ +0.84000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32S3ESP32S2ESP32C3ESP32C6ESP32
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
Matter/examples/MatterMinimum‼️ +12K0‼️ +13K⚠️ +16‼️ +14K0‼️ +14K0‼️ +13K0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Matter Issues and Feature Request about Matter Protocol Type: Bug 🐛 All bugs Type: Example Issue is related to specific example.
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

2 participants