Prevent infinite DAG growth #2892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some circumstances where files repeatedly get updated, such as when a .xrl file re-generates a .erl file on each compile run, the DAG analysis would repeatedly re-add edges for this file's dependencies (such as include files) to the DAG. Since the digraph module de-dupes vertices but not edges (duplicate edges is a valid use case), we add an explicit check for edge presence before re-adding them. This should properly prevent unexpected growth of DAG files. From manual testing, we get stability when going from a fresh DAG, but if it already had many dupes, the file size may jump around a bit regardless.
tsloughter
reviewed
Jun 5, 2024
| RemainingEdges = [digraph:edge(G, E) || E <- digraph:out_edges(G, Source), | ||
| AbsIncls =/= []], | ||
| [digraph:add_edge(G, Source, Incl) || Incl <- AbsIncls, | ||
| not in_edges(Source, Incl, RemainingEdges)], |
There was a problem hiding this comment.
So add it if its not already in the edges?
There was a problem hiding this comment.
yeah. Problem was that edges can be duplicated and I assumed they weren't.
There was a problem hiding this comment.
Ok, surprised me too seeing this patch.
|
Hello. I'm immediately experiencing a problem with slow pull of dependencies. I use the git _subdir option, each dependency takes at least 15 minutes to pull. I installed rebar3 from the nightly build, but it didn't help me |
|
This seems unrelated to this issue. Please open a stand-alone issue while following the instructions in the template. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some circumstances where files repeatedly get updated, such as when a .xrl file re-generates a .erl file on each compile run, the DAG analysis would repeatedly re-add edges for this file's dependencies (such as include files) to the DAG. Since the digraph module de-dupes vertices but not edges (duplicate edges is a valid use case), we add an explicit check for edge presence before re-adding them.
This should properly prevent unexpected growth of DAG files.
From manual testing, we get stability when going from a fresh DAG, but if it already had many dupes, the file size may jump around a bit regardless.