Prevent XRef issue when analysis runs on generated code #2829
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
It is not guaranteed that a generated module contains a
file
attribute. I've seenerlydtl
-generated modules that don't have it.It's potentially possible to not see the error by making use of
xref_queries
(?) though I didn't test that thoroughly (I will have to eventually use it though, since some generated modules do appear to have the file attribute, but I'm still to understand where it's coming from).On the other hand, instead of simply removing the analysis (as per the code comment) we could also output a special
with the error.
Review notes
Probably best seen with "Hide whitespace" enabled.