-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vendor structure #2720
Vendor structure #2720
Conversation
Looks like this is blowing up shelltests, mostly around releases. Not too sure about that, will have to dig a bit. E: was related to missing template data in a partially moved escript config |
Oh, fun gotcha: this breaks dialyzer by analyzing deps that were previously not covered... |
This is a prerequisite for vendoring and demands that we move all source files around, and update the helper scripts (like bootstrap) to work with it. This should have no consequence on rebar3 users aside from needing to fetch a git_subdir if they need the content for it.
And fix Dialyzer oddities
Will you release this in a minor version soon? |
Probably could be doable, we haven't heard any feedback positive or otherwise though, so it's hard to say if it's ready to go. |
We have tested it and it seems to work well. :-) We would prefer a release. |
Still interested in a release. Thanks. |
It's finally out, needed CI to work end-to-end to make it all go! |
This PR is in two parts, and is a proposal to switch up how we do things to facilitate
corporate use cases and the job of linux distribution package maintainers.
Migrate to an umbrella structure
This is a prerequisite for vendoring and demands that we move all source
files around, and update the helper scripts (like bootstrap) to work
with it.
This should have no consequence on rebar3 users aside from needing to
fetch a git_subdir if they need the content for it.
Vendor all dependencies, make bootstrap use them
This makes rebar3 use de-facto offline bootstrap, and avoids hitting the network
to fetch certs anywhere else but when a developer flushes all source files and
re-fetches certifi.
This is done by calling
rebar3 as experimental vendor
.