reset hooks under profiles for application opts #1564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferd
reviewed
Jun 2, 2017
src/rebar_app_discover.erl
Outdated
| not lists:member(Key, [post_hooks, | ||
| pre_hooks, | ||
| provider_hooks, | ||
| artifacts])]}; |
There was a problem hiding this comment.
I'd extract that list of magic keys to escape here and on line 188 to some shared variable or macro so they always end up matching.
ferd
reviewed
Jun 2, 2017
test/rebar_hooks_SUITE.erl
Outdated
| @@ -98,6 +100,17 @@ run_hooks_once(Config) -> | |||
| rebar_test_utils:create_app(AppDir, Name, Vsn, [kernel, stdlib]), | |||
| rebar_test_utils:run_and_check(Config, RebarConfig, ["compile"], {ok, [{app, Name, valid}]}). | |||
|
|
|||
| %% test that even if a hook is defined in a used profile it is not run twice | |||
There was a problem hiding this comment.
The discussion on IRC mentioned things that looked like umbrella apps, but here it doesn't seem to matter?
There was a problem hiding this comment.
The test does create an umbrella app, just like the one above it, just with the extra piece that it uses a profile. I can add that fact to the comment.
tsloughter
force-pushed
the
reset_profile_hooks
branch
2 times, most recently
from
f724cf1 to
18628fd
Compare
ferd
approved these changes
Jun 2, 2017
tsloughter
force-pushed
the
reset_profile_hooks
branch
from
18628fd to
48dc973
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.