rebar_utils:escape_chars handles quotes #1504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebar_file_utils:cp_r uses rebar_utils:escape_chars to ensure that the file names are safe to use, but it doesn't escape double and single quotes. If the file name includes those characters, they disappear when the shell processes them and we get "file not found" errors. The main culprit here is eunit, that creates reports whose names are `TEST-file_"myfile.app".xml`, and I wish it didn't but I think escape_chars should still do its job all the way.
ferd
added a commit
to ferd/rebar3
that referenced
this pull request
Mar 23, 2017
- [OSX tests added to CI](erlang#1471), joining linux and windows 10 - [upgrade relx to 3.22.3](erlang#1518), [fixing multiple issues](https://github.com/erlware/relx/releases/tag/v3.22.3) - [Fixing eunit errors in 19.3 when `init_per_*` isn't paired with `end_per_*`](erlang#1516) - [Allow single test spec in ct_opts](erlang#1506) - [Properly warn when missing inets at runtime](erlang#1505) - [rebar_utils:escape_chars handles quotes in paths](erlang#1504) - [Fix typo in help text for upgrade command](erlang#1503) - [change package version warnings to debug level](erlang#1502) - [Path-type sensitive .cmd creation for escripts](erlang#1500) - [Windows escripts get cmd autogenerated](erlang#1494) - [REBAR_CONFIG impacts config file for project root only](erlang#1497) - [Fix wildcard usage in rebar3 clean](erlang#1498) - [Bump cth_readable to 1.2.4](erlang#1496) (fixing some erroneous reports when suites get skipped) - [Add respect for src_dirs option in app_discover and app_info](erlang#1486) - [Add support for global plugin-defined templates](erlang#1473) - [catch badarg exception from eunit in `rebar_prv_eunit`](erlang#1472)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rebar_file_utils:cp_r uses rebar_utils:escape_chars to ensure that the file names are safe to use, but it doesn't escape double and single quotes. If the file name includes those characters, they disappear when the shell processes them and we get "file not found" errors.
The main culprit here is eunit, that creates reports whose names are
TEST-file_"myfile.app".xml, and I wish it didn't but I think escape_chars should still do its job all the way.