Allow exclusion of apps in cover #1463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferd
reviewed
Jan 30, 2017
| false -> filter_checkouts(Rest, [App|Acc]) | ||
| filter_checkouts_and_excluded([], _ExclApps, Acc) -> lists:reverse(Acc); | ||
| filter_checkouts_and_excluded([App|Rest], ExclApps, Acc) -> | ||
| case rebar_app_info:is_checkout(App) or lists:member(rebar_app_info:name(App), ExclApps) of |
There was a problem hiding this comment.
should use orelse to use shortcircuiting expressoins
Adds a new option `{cover_excl_apps, Apps}` to exclude apps from coverage
analysis by name.
varnerac
force-pushed
the
cover_exclude_apps
branch
from
be6f054 to
9b099f4
Compare
|
I changed |
|
Sounds good to me. @talentdeficit any opinions? |
|
this looks good to me, we should probably document it tho |
|
I am happy to document this after merge. I did not see documentation instructions in the CONTRIBUTING doc. |
|
They're on rebar.org -- the commands section for example, contains a list of config values possible for each command, and the configuration section also does although in a different format. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new option
{cover_excl_apps, Apps}to exclude apps from coverageanalysis by name.