Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add get-deps provider #1405

Merged
merged 1 commit into from
Dec 9, 2016
Merged

add get-deps provider #1405

merged 1 commit into from
Dec 9, 2016

Conversation

talentdeficit
Copy link
Contributor

a no-op provider that depends on lock that is slightly more discoverable and user friendly

a no-op provider that depends on lock that is slightly more discoverable and user friendly
@tsloughter
Copy link
Collaborator

@talentdeficit
Copy link
Contributor Author

someone on slack had a valid use case!

and it was @ferd!

@ferd
Copy link
Collaborator

ferd commented Dec 7, 2016

Yeah one was fetching deps just before putting them in a docker image without having compiled them. At least get-deps does not carry the feeling of "I want to install a dep in a directory" or something.

@tsloughter
Copy link
Collaborator

Fine :). And I guess the name should stay as get-deps since it is what people from rebar2 would expect.

@ferd
Copy link
Collaborator

ferd commented Dec 8, 2016

yeah. I was toying with the idea of rebar3 prepare but I guess it would be very ambiguous in terms of what it should do. I don't have any strong opposition to get-deps either. Do we want the docline for the command to refer to the lockfile or we mostly ignore it?

@alinpopa
Copy link
Contributor

alinpopa commented Dec 8, 2016

Sorry guys, I sort of needed that, but @ferd pointed me to rebar3 lock which works fine for me. Thanks. But I do agree that get-deps is "slightly more discoverable and user friendly".

@ferd ferd merged commit ffd9771 into master Dec 9, 2016
@ferd ferd deleted the get-deps branch May 6, 2018 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants