Add 'recursive' option #1382
Add 'recursive' option #1382
Conversation
The option {recursive,boolean()} can now be set pr directory in
'src_dirs' and 'extra_src_dirs', and on top level in the new
'erlc_compiler' option. Example config:
{erlc_compiler,[{recursive,false}]}.
{src_dirs,[{"src",[{recursive,true}]}]}.
This will cause recursive compilation within the "src" directory, but
not in any other directoires.
sirihansen
force-pushed
the
siri/recursive-opt
branch
from
a8ecd11 to
44fabbb
Compare
|
this looks good to me, but i'm gonna leave it open for @ferd or @tsloughter to give final approval |
|
I think it looks clean too. The only thing I want to check before merging it is if any of the common plugins we have (and even rebar3 internals) use the opts to get the |
|
A quick ack check seems to say that rebar3 itself looks good with it. |
|
rebar3_eqc and rebar3_proper do some raw manipulation (similar to what eunit and CT were doing) but should be safe-ish I think. Mostly keydelete or adding entries. Sounds like this is good to merge. Sorry for the delays. |
This pull request adds the option {recursive,boolean()}, indicating whether or not rebar3 should search recursively for source files to compile. The options can be set on two levels:
top level - sets the default for the project:
{erlc_compiler,[{recursive,boolean()}]}.per source directory:
{src_dirs,[{"src",[{recursive,boolean()}]}]}.{extra_src_dirs,[{"test",[{recursive,boolean()}]}]}.The variants are chosen after the discussion in issue #1345.
This feature is needed for testing of split-out applications from erlang/OTP, where data dirs (*_SUITE_data) in test contain .erl files that must not be compiled by rebar3. Reasons for this can be
a) the files should not be compiled at all, e.g. because the test suite operates on the .erl files.
b) the files must be compiled with specific options which shall not be applied to other source files (e.g. specific output directories)
For b) we need to let the test suite itself do the compilation. Earlier this was solved with a Makefile and some internal code in our test environment, but we are probably aiming at removing this.