Prevent crashing when mv warns and report warnings to the user instead.

[ddeboer]

Fix #1324.

In some cases, mv will throw a warning, while still moving the files correctly and returning a 0 return code:

"mv: can't preserve ownership of ... Permission denied".

[ddeboer]

Should there be a test for this as well? Not sure how I can mock rebar_utils:sh/2.

[ferd]

I'd change the string to "mv: ~p" there.

[ferd]

A test would be good. We may not need to mock anything -- if we can make a file inside CT's priv_dir argument, and give it permissions that would be lost it would be good. If we depend on a specific environment for this to work (i.e. multiple mount points), then yeah we'd need to mock otherwise and skip tests and so on.

To mock rebar_utils:sh/2 I'd probably just:

meck:new(rebar_utils, [passthrough]),
meck:expect(rebar_utils, sh, fun(<STRING_FOR_MV>, _) -> {ok, "Warning"}  end),
ok = rebar_utils:mv(Src, Dest),
meck:unload(rebar_utils).

We possibly do not need to test that the warning is being relayed, though that would be nicer and would require more mocking (and conditional test skips for windows runs).

[ddeboer]

If we depend on a specific environment for this to work (i.e. multiple mount points), then yeah we'd need to mock otherwise and skip tests and so on.

Added a test. Mocking, because I wasn’t able to reproduce mv throwing a warning when transferring within one filesystem.

[ddeboer]

And now green. 😉

[ferd]

Merging, thanks!

[ddeboer]

Thank you for the help, Fred!