Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #1185 git on windows #1206

Closed
wants to merge 1 commit into from
Closed

fix #1185 git on windows #1206

wants to merge 1 commit into from

Conversation

postHawk
Copy link
Contributor

incorrect write last commit and release building.

incorrect write last commit and release building.
@ferd
Copy link
Collaborator

ferd commented Aug 10, 2016

The tests keep failing. Will this get updated or should we close it?

@ferd ferd added the awaiting update requiring action from submitter label Aug 10, 2016
@filmor
Copy link
Contributor

filmor commented Aug 18, 2016

This is fixed by #1251 already, I think this PR is superfluous.

/edit: Said #1206 before

@ferd
Copy link
Collaborator

ferd commented Aug 18, 2016

@filmor this is #1206 already. I think this PR is critical to your argument here :)
Also the tests are apparently failing as said in a prior comment.

@filmor
Copy link
Contributor

filmor commented Aug 18, 2016

Oops, sorry, I corrected the reference ;)

Nevertheless, the problem at hand is fixed in master already.

/edit: Okay, the first part of the PR is superfluous (the stuff around git rev-parse), I don't know about the second part, sorry for the noise.

@ferd
Copy link
Collaborator

ferd commented Aug 18, 2016

Ah good to know. Will close the other ones you have hilighted as already fixed, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting update requiring action from submitter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants