Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blacklist apps to reload #1147

Merged
merged 1 commit into from
Apr 4, 2016
Merged

Conversation

ferd
Copy link
Collaborator

@ferd ferd commented Apr 4, 2016

When an app contains one of the modules we can't afford to get upgraded
without breakage (i.e. erlware_commons, providers, getopt), skip
reloading that application from the rebar3 agent, such that it can keep
on working in subsequent calls.

Blacklisted:

  • erlware_commons (broke on ec_cmd_log)
  • providers (core to functionality)
  • cf (useful to not explode on colors)
  • cth_readable (only used for CT suites, but incompatibilities may break
    whole runs)

When an app contains one of the modules we can't afford to get upgraded
without breakage (i.e. erlware_commons, providers, getopt), skip
reloading that application from the rebar3 agent, such that it can keep
on working in subsequent calls.

Blacklisted:

- erlware_commons (broke on ec_cmd_log)
- providers (core to functionality)
- cf (useful to not explode on colors)
- cth_readable (only used for CT suites, but incompatibilities may break
  whole runs)
@tsloughter
Copy link
Collaborator

Cool, +1.

@tsloughter tsloughter merged commit 86054f2 into erlang:master Apr 4, 2016
@ferd ferd deleted the blacklist-shell-reloads branch April 4, 2016 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants