Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR starts using safeframe under the hood, with an emphasis on minimizing breaking changes and making this switch as invisible as possible to the user.
Some decisions to resolve:
tags()
has been switched to usevar = label
in place of the previouslabel = var
to help with evaluate the usage oftag_names
as arguments inmake_linelist
using autocomplete #144. However, this means thattags(x, show_null = TRUE)
is no longer closely aligned withtags_defaults()
validate_linelist()
now errors when all default tags are not present (validate_linelist()
does not error when default tags are not all present #155). Is this what we want?TODO:
Supersedes #150