Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework RequiredMessageParts API #85

Merged
merged 1 commit into from
Jan 5, 2025

Conversation

fjarri
Copy link
Member

@fjarri fjarri commented Jan 5, 2025

Make RequiredMessageParts API follow a kind of a builder pattern. This leads to:

  • somewhat shorter lines when only one part of the message is needed
  • allowing to require two out of three parts of the messages

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12623714642

Details

  • 1 of 12 (8.33%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 69.821%

Changes Missing Coverage Covered Lines Changed/Added Lines %
manul/src/protocol/round.rs 1 12 8.33%
Totals Coverage Status
Change from base Build 12621981989: 0.1%
Covered Lines: 1830
Relevant Lines: 2621

💛 - Coveralls

@fjarri fjarri merged commit b66f762 into entropyxyz:master Jan 5, 2025
8 checks passed
@fjarri fjarri deleted the more-required-message-methods branch January 5, 2025 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants