Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Internal_Core #11506

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Refactor Internal_Core #11506

merged 1 commit into from
Nov 7, 2024

Conversation

AdRiley
Copy link
Member

@AdRiley AdRiley commented Nov 7, 2024

Pull Request Description

Applies the new module private rules to the module previously called Internal_Core.

I hope that this is a good example of the benefits of the new approach.

The main changes are

  • renaming the module to Upload_Table
  • defining the public API and private implementation of Upload_Table

And I believe it actually finds a defect in that previously the usage in Delete.Enso was calling directly into the (now private) method _create_in_memory_table_upload_op which bypassed the shared logic that lives in the (now explicity public) create_table_upload_operation

image

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
  • If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

@AdRiley AdRiley added the CI: No changelog needed Do not require a changelog entry for this PR. label Nov 7, 2024
@AdRiley AdRiley merged commit 014a2a7 into develop Nov 7, 2024
36 of 37 checks passed
@AdRiley AdRiley deleted the wip/adr/refactor-internal-core branch November 7, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants