Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only single native image is built at a time #11497

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

Akirathan
Copy link
Member

@Akirathan Akirathan commented Nov 5, 2024

Pull Request Description

#10783 introduced another definition of a buildnativeimage task. Since that time, our CI is transiently failing on out of memory error. This PR ensures that there can be just a single buildNativeImage task running at a time.

Important Notes

Manually tested by running

sbt:enso> all engine-runner/buildNativeImage project-manager/buildNativeImage

And looking at spawn subprocesses. On develop, I have two native-image processes, on this PR, there is just a single one.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
  • If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

@Akirathan Akirathan self-assigned this Nov 5, 2024
@Akirathan Akirathan added the CI: No changelog needed Do not require a changelog entry for this PR. label Nov 5, 2024
Copy link
Member

@JaroslavTulach JaroslavTulach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a black magic or sbt trick! This is completely different fix than I was envisioning. If it does the job, then great, however.

@Akirathan Akirathan added the CI: Clean build required CI runners will be cleaned before and after this PR is built. label Nov 5, 2024
Copy link
Contributor

@4e6 4e6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into that ❤️

@Akirathan Akirathan added the CI: Ready to merge This PR is eligible for automatic merge label Nov 5, 2024
@mergify mergify bot merged commit 3df5755 into develop Nov 5, 2024
41 of 43 checks passed
@mergify mergify bot deleted the wip/akirathan/native-image-single-proc branch November 5, 2024 18:34
Copy link
Collaborator

@hubertp hubertp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: Clean build required CI runners will be cleaned before and after this PR is built. CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants