-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SQLServer enable filter #11471
SQLServer enable filter #11471
Conversation
cc870c2
to
e5baf3d
Compare
distribution/lib/Standard/Database/0.0.0-dev/src/Dialect_Flag.enso
Outdated
Show resolved
Hide resolved
distribution/lib/Standard/Microsoft/0.0.0-dev/src/Internal/SQLServer_Dialect.enso
Outdated
Show resolved
Hide resolved
distribution/lib/Standard/Microsoft/0.0.0-dev/src/Internal/SQLServer_Dialect.enso
Outdated
Show resolved
Hide resolved
distribution/lib/Standard/Microsoft/0.0.0-dev/src/Internal/SQLServer_Dialect.enso
Outdated
Show resolved
Hide resolved
distribution/lib/Standard/Microsoft/0.0.0-dev/src/Internal/SQLServer_Dialect.enso
Outdated
Show resolved
Hide resolved
distribution/lib/Standard/Microsoft/0.0.0-dev/src/Internal/SQLServer_Dialect.enso
Show resolved
Hide resolved
distribution/lib/Standard/Microsoft/0.0.0-dev/src/Internal/SQLServer_Dialect.enso
Outdated
Show resolved
Hide resolved
distribution/lib/Standard/Microsoft/0.0.0-dev/src/Internal/SQLServer_Dialect.enso
Outdated
Show resolved
Hide resolved
distribution/lib/Standard/Microsoft/0.0.0-dev/src/Internal/SQLServer_Dialect.enso
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall shape looks great and aligned with what we discussed. Sorry if I'm asking for too many additional things if this is just an iterative improvement and supposed to be still improved in future iterations - I do understand some of my comments may just be things 'for later'.
For now:
- I'd like to refactor some copy pasted code as it should increase clarity and maintainability:
- the conversions in both directions - as this will make it much clearer where we are crossing boundaries between the boolean world and value world. Also BTW I'd suggest updating the docstring of
_generate_expression
with this 'two kinds of values' metaphor, as IMHO it is really helpful in understanding this whole ordeal. - minor thing but the application of metadata to the operation that was copied from
Base_Generator
should also be refactored IMHO.
- the conversions in both directions - as this will make it much clearer where we are crossing boundaries between the boolean world and value world. Also BTW I'd suggest updating the docstring of
- I really don't understand why we have a separate top-level
_generate_column
function. As far as we discussed, it seems that there is nothing really special about a column - it is just a thing that expects a 'value level' expression and not booleans. So I'd assume I should just be able to call_generate_expression
withgenerate_as_bool=False
and it should work. If not, why?
distribution/lib/Standard/Microsoft/0.0.0-dev/src/Internal/SQLServer_Dialect.enso
Outdated
Show resolved
Hide resolved
52dc9ba
to
1f80976
Compare
Pull Request Description
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
or the Snowflake database integration, a run of the Extra Tests has been scheduled.