Fix for ID caching #230
Merged
Fix for ID caching #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rebuilds the cache every time a group or permission is added / deleted (create_perm, delete_perm, create_group, delete_group).
|
@REJack Merge pls ? |
REJack
reviewed
May 14, 2018
application/libraries/Aauth.php
Outdated
| $query = $this->aauth_db->get($this->config_vars['perms']); | ||
|
|
||
| foreach ($query->result() as $row) { | ||
| $key = str_replace(' ', '', trim(strtolower($row->name))); | ||
| $this->cache_perm_id[$key] = $row->id; | ||
| } |
There was a problem hiding this comment.
This curly bracket should not removed! It's cause a error.
There was a problem hiding this comment.
@REJack Sorry, my mistake, I edited this by the tablet haha, fixed
omkartapale
reviewed
Jun 24, 2018
| /** | ||
| * precache_perms() caches all permission IDs for later use. | ||
| */ | ||
| private function precache_perms { |
There was a problem hiding this comment.
The function name line should be as follows:
private function precache_perms() {
Observer the missing '()' after the function name
There was a problem hiding this comment.
And the same thing with the function
precache_groups
omkartapale
reviewed
Jun 24, 2018
| /** | ||
| * precache_groups() caches all group IDs for later use. | ||
| */ | ||
| private function precache_groups { |
There was a problem hiding this comment.
The function name line should be as follows:
private function precache_groups() {
Observer the missing '()' after the function name
There was a problem hiding this comment.
This will address issue #234
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebuilds the cache every time a group or permission is added / deleted (create_perm, delete_perm, create_group, delete_group).