Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] link zlib statically, with better test #42

Merged
merged 2 commits into from
Apr 8, 2018

Conversation

mriehl
Copy link
Contributor

@mriehl mriehl commented Mar 26, 2018

See #41 #38

Fixes #37

This is basically #38 with the tests encoded using cargo new semantics (no docker volume for the project)

@mriehl
Copy link
Contributor Author

mriehl commented Mar 26, 2018

Here's the travis job: https://travis-ci.org/mriehl/rust-musl-builder/jobs/358272959
I hope I didn't break the travis config while refactoring, standing by..

@mriehl
Copy link
Contributor Author

mriehl commented Mar 26, 2018

@mriehl
Copy link
Contributor Author

mriehl commented Mar 26, 2018

Note that I tested the "file check" locally too. This was missing as pointed out by @bomgar because if the file doesn't exist, ldd also fails (with the same exit code).
There's a bit of duplication in the file path, but using a variable is such a fuckery in the multiline string (especially since I wanted to split it into path components because the test is slow as hell so getting tree like output is critical imho)

@mriehl mriehl changed the title [fix] link zlib with test [fix] link zlib statically, with better test Mar 26, 2018
@bomgar
Copy link
Contributor

bomgar commented Apr 3, 2018

@emk isn't this exactly what you wanted?

@emk emk merged commit 2b8bab3 into emk:master Apr 8, 2018
@emk
Copy link
Owner

emk commented Apr 8, 2018

Merged after overhauling the tests. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants