-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EVM plugin wallet provider and transfer action improvements #1701
EVM plugin wallet provider and transfer action improvements #1701
Conversation
I had to remove the Twitter client and update the plugin-story types locally to successfully build and run the project. Specifically, I updated the story configuration object that was causing build failures and removed the Twitter client, which was preventing the project from starting. However, these fixes are unrelated to the changes in this PR and were not committed, they would require separate attention to address properly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks for improving this. Yeah the plugin story should have been address yesterday if you are still having issues after rebasing to latest develop then this is new and will be handled separately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Relates to:
N/A
Risks
Low.
Background
What does this PR do?
This PR introduces improvements and fixes to the EVM plugin:
template
field from the transfer action, aligning it with its intended type and improving clarity.What kind of change is this?
Why are we doing this? Any context or related work?
Documentation changes needed?
My changes do not require a change to the project documentation.
Testing
Where should a reviewer start?
WalletProvider
) for caching logic.Detailed testing steps
Deploy Notes
No specific deploy instructions needed; automated tests and regular deployment process suffice.
Discord username
nikita_zhou
Screenshots
Agent interaction
Link to the tx: https://testnet.iotexscan.io/tx/f946fce5bc127761bd780444bf2d3180bf66fa4944b37e803767e99e76dd0d13
Caching
Linting
Testing