-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: client-twitter lowerCase bug and environment clean up (+lint fixes, and TWITTER_SEARCH_ENABLE double start fix) #1514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odilitime
changed the title
chore: client-twitter environment clean up (+lint fixes, and twitter search start fix)
chore: client-twitter environment clean up (+lint fixes, and TWITTER_SEARCH_ENABLE double start fix)
Dec 28, 2024
odilitime
added
needs_documentation
and removed
documentation
Improvements or additions to documentation
labels
Dec 28, 2024
odilitime
force-pushed
the
test-eliza
branch
from
December 28, 2024 04:10
d9aa0cd
to
d15588d
Compare
odilitime
changed the title
chore: client-twitter environment clean up (+lint fixes, and TWITTER_SEARCH_ENABLE double start fix)
fix: client-twitter lowerCase bug and environment clean up (+lint fixes, and TWITTER_SEARCH_ENABLE double start fix)
Dec 28, 2024
shakkernerd
previously approved these changes
Dec 28, 2024
odilitime
dismissed
shakkernerd’s stale review
December 28, 2024 07:32
The merge-base changed after approval.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Risks
medium, I changed the scale of ACTION_INTERVAL from ms to mins
Background
What does this PR do?
What kind of change is this?
Bug fixes (non-breaking change which fixes an issue)
Why are we doing this? Any context or related work?
Just tested and started cleaning things up
Documentation changes needed?
My changes require a change to the project documentation. ACTION_INTERVAL scale changed from ms to minute