Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: client-twitter lowerCase bug and environment clean up (+lint fixes, and TWITTER_SEARCH_ENABLE double start fix) #1514

Merged
merged 25 commits into from
Dec 28, 2024

Conversation

odilitime
Copy link
Collaborator

@odilitime odilitime commented Dec 28, 2024

Risks

medium, I changed the scale of ACTION_INTERVAL from ms to mins

Background

What does this PR do?

  • fixes:
 ⛔ ERRORS
   Error starting agent for character X: 
   {} 

 ["⛔ TypeError: Cannot read properties of null (reading 'toLowerCase')"] 

 ⛔ ERRORS
   Error starting agents: 
   {} 
  • don't run search twice if TWITTER_SEARCH_ENABLE is enabled
  • only parses config once on agent start
  • also fixing various issues lint found

What kind of change is this?

Bug fixes (non-breaking change which fixes an issue)

Why are we doing this? Any context or related work?

Just tested and started cleaning things up

Documentation changes needed?

My changes require a change to the project documentation. ACTION_INTERVAL scale changed from ms to minute

@odilitime odilitime added the documentation Improvements or additions to documentation label Dec 28, 2024
@odilitime odilitime changed the title chore: client-twitter environment clean up (+lint fixes, and twitter search start fix) chore: client-twitter environment clean up (+lint fixes, and TWITTER_SEARCH_ENABLE double start fix) Dec 28, 2024
@odilitime odilitime added needs_documentation and removed documentation Improvements or additions to documentation labels Dec 28, 2024
@odilitime odilitime changed the title chore: client-twitter environment clean up (+lint fixes, and TWITTER_SEARCH_ENABLE double start fix) fix: client-twitter lowerCase bug and environment clean up (+lint fixes, and TWITTER_SEARCH_ENABLE double start fix) Dec 28, 2024
shakkernerd
shakkernerd previously approved these changes Dec 28, 2024
@odilitime odilitime dismissed shakkernerd’s stale review December 28, 2024 07:32

The merge-base changed after approval.

@shakkernerd shakkernerd merged commit 12407dc into elizaOS:develop Dec 28, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants